Re: [PATCH v2 1/4] selftests/ftrace: Add generic boot tracing test framework

[Google]

On Wed, 12 Aug 2026 00:34:27 +0900
"Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

> +# Verify busybox architecture compatibility
> +if command -v file >/dev/null 2>&1; then
> +	BUSYBOX_INFO="$(file -b "$BUSYBOX" 2>/dev/null || true)"

Sashiko pointed:
> 
> Will this check skip the tests incorrectly if the busybox binary is a symbolic
> link?
> The file command is invoked without the -L (dereference) flag. If the provided
> busybox path is a symbolic link, the file command will output "symbolic link
> to..." rather than the actual executable architecture. This causes it to fall
> through the case statement below and incorrectly skip the test suite on
> supported architectures.
> Could this use file -bL instead?

Yeah, I forgot that case. Let me fix it.

Thanks,


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>