Re: [PATCH 1/2] dt-bindings: clock: qcom: Add Hawi camera clock controller

[Mike Tipton]

On Fri, Aug 07, 2026 at 04:50:46PM -0500, Rob Herring wrote:
> On Thu, Jul 23, 2026 at 02:38:57PM -0700, Vivek Aknurwar wrote:
> > Update the compatible and bindings for camera clock controller (CAMCC)
> > support on the Qualcomm Hawi SoC.
> 
> That's obvious from the diff. Explain how the block is the same or 
> different in Hawi.
> 
> > 
> > Signed-off-by: Vivek Aknurwar <vivek.aknurwar@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/clock/qcom,sm8450-camcc.yaml          |  36 +++--
> >  include/dt-bindings/clock/qcom,hawi-camcc.h        | 165 +++++++++++++++++++++
> >  2 files changed, 192 insertions(+), 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> > index b41247b257b1..cdc19418c064 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> > @@ -16,6 +16,7 @@ description: |
> >    domains on SM8450.
> >  
> >    See also:
> > +    include/dt-bindings/clock/qcom,hawi-camcc.h
> >      include/dt-bindings/clock/qcom,kaanapali-camcc.h
> >      include/dt-bindings/clock/qcom,kaanapali-cambistmclkcc.h
> >      include/dt-bindings/clock/qcom,sm8450-camcc.h
> > @@ -26,15 +27,21 @@ description: |
> >  
> >  properties:
> >    compatible:
> > -    enum:
> > -      - qcom,kaanapali-cambistmclkcc
> > -      - qcom,kaanapali-camcc
> > -      - qcom,sm8450-camcc
> > -      - qcom,sm8475-camcc
> > -      - qcom,sm8550-camcc
> > -      - qcom,sm8650-camcc
> > -      - qcom,sm8750-cambistmclkcc
> > -      - qcom,sm8750-camcc
> > +    oneOf:
> > +      - enum:
> > +          - qcom,hawi-camcc
> > +          - qcom,kaanapali-cambistmclkcc
> > +          - qcom,kaanapali-camcc
> > +          - qcom,sm8450-camcc
> > +          - qcom,sm8475-camcc
> > +          - qcom,sm8550-camcc
> > +          - qcom,sm8650-camcc
> > +          - qcom,sm8750-cambistmclkcc
> > +          - qcom,sm8750-camcc
> > +      - items:
> > +          - enum:
> > +              - qcom,hawi-cambistmclkcc
> > +          - const: qcom,kaanapali-cambistmclkcc
> >  
> >    clocks:
> >      items:
> > @@ -67,6 +74,17 @@ required:
> >  
> >  allOf:
> >    - $ref: qcom,gcc.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          not:
> > +            contains:
> > +              enum:
> > +                - qcom,kaanapali-cambistmclkcc
> > +                - qcom,sm8750-cambistmclkcc
> > +    then:
> > +      required:
> > +        - '#power-domain-cells'
> 
> This makes #power-domain-cells required on existing platforms. That's a 
> separate patch and needs to be explained.

It was functionally required already but was never documented as such.
All the pre-existing "-camcc" compatible devices register genpds for
their GDSCs. And all these camcc devices already include
#power-domain-cells properties, so this change shouldn't cause any DT
validation failures (at least for any in-tree).

It could certainly be moved to a separate patch though. Hawi isn't
actually changing the fundamental requirement here.

Thanks,
Mike