Re: [PATCH 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer

[Rob Herring]

On Thu, Aug 06, 2026 at 02:46:27PM +0200, Kanak Shilledar wrote:
> ICM42370P is a 3-axis accelerometer. The device can support
> I2C, SPI and I3C. Add the supporting devicetree documentation for I2C as
> we have only tested using I2C protocol and leave the reset for future
> work.
> 
> The device supports VDD and VDDIO operating range of 1.71V to 3.6V.
> 
> Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> ---
>  .../bindings/iio/accel/invensense,icm42370.yaml    | 65 ++++++++++++++++++++++
>  MAINTAINERS                                        |  8 +++
>  2 files changed, 73 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/invensense,icm42370.yaml b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370.yaml
> new file mode 100644
> index 0000000000000..561e798b911ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/invensense,icm42370.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICM-42370 Accelerometer
> +
> +maintainers:
> +  - Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> +  - Henrik Grimler <henrik.grimler@xxxxxxxx>
> +
> +description: |
> +  3-axis accelerometer MotionTracking device.
> +
> +  It supports I3C, I2C and SPI serial communication, has a 2.25kB FIFO
> +  and 2 programmable interrupts with low-power wake-on-motion support.
> +
> +  It also has programmable filters and an embedded temperature sensor.
> +
> +  https://uat.invensense.com/en-us/products/3-axis/icm-42370-p
> +
> +properties:
> +  compatible:
> +    const: invensense,icm42370
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  drive-open-drain:
> +    type: boolean

Drive what open drain? Presumably the interrupt? Add a description.

> +
> +  vdd-supply:
> +    description: Regulator operating range between 1.71V to 3.6V.
> +
> +  vddio-supply:
> +    description: Regulator operating range between 1.71V to 3.6V.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        icm42370@69 {

accelerometer@69
 
> +            compatible = "invensense,icm42370";
> +            reg = <0x69>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> +            vdd-supply = <&vdd>;
> +            vddio-supply = <&vddio>;
> +        };
> +    };