Re: [PATCH 1/2] iio: light: vcnl4000: use correct channel array size
From: Tsz Shan Chan
Date: Wed Aug 12 2026 - 20:24:07 EST
On Wed, Aug 12, 2026 at 04:39:14AM +0100, Jonathan Cameron wrote:
> On Tue, 11 Aug 2026 12:53:22 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
>
> > On Tue, Aug 11, 2026 at 05:07:24PM +1000, Tsz Shan Chan wrote:
> > > Use ARRAY_SIZE(vcnl4040_channels) for num_channels to match .channels.
> >
> > I was under impression that I have seen this patch a few months ago.
> > In any case sounds like a fix and hence needs a Fixes tag.
> >
> They are both the same size == 2 I think.
>
> So whilst nice to fix this I don't see it as needing a fixes tag
> as such. It would be helpful if the patch description called
> out that the ARRAY_SIZE() of the wrong array happens to match the
> one it should be.
>
> Jonathan
>
>
Thanks. Will update the commit message and send a v2.