Re: [PATCH v5 1/2] dt-bindings: pinctrl: microchip,pic32mzda-pinctrl: Convert to DT schema
From: Uday Kiran
Date: Thu Aug 13 2026 - 13:30:55 EST
On Tue, Aug 4, 2026 at 3:54 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
>
>
> On Fri, 31 Jul 2026 23:15:51 +0530, Udaya Kiran Challa wrote:
> > Convert Microchip PIC32 Pin Controller devicetree binding
> > from legacy text format to DT schema.
> >
> > Signed-off-by: Udaya Kiran Challa <challauday369@xxxxxxxxx>
> > ---
> > Changelog:
> > Changes since v4:
> > - Add reference to pincfg-node.yaml
> >
> > Link to v4:https://lore.kernel.org/all/20260722123243.341346-1-challauday369@xxxxxxxxx/
> >
> > Changes since v3:
> > - Drop "|" from description fields
> > - Remove '#address-cells' and '#size-cells' properties from the schema
> > - Consolidate repeated pin-node property definitions into a single
> > $defs/pin-node entry
> > - Replace the two patternProperties blocks with additionalProperties
> > using oneOf to allow either:
> > - container nodes holding nested pin configuration nodes, or
> > - direct pin configuration nodes.
> > - Update $ref to use the absolute schema path
> > /schemas/pinctrl/pinmux-node.yaml#
> >
> > Link to v3:https://lore.kernel.org/all/20260719183431.124061-1-challauday369@xxxxxxxxx/
> >
> > Changes since v2:
> > - Add container node for grouped pin configuration sub-nodes
> > - Correct regex patterns of direct and nested child nodes
> > - Fix interrupts values in uart2 example
> >
> > Link to v2:https://lore.kernel.org/all/20260707144223.120417-1-challauday369@xxxxxxxxx/
> >
> > Changes since v1:
> > - Add interrupts and clocks to uart2 example to satisfy uart schema validation
> > - Corect regex patterns to accept standard DT node naming conventions
> > - Add function property to top-level pin configuration nodes
> > - Remove restrictive enum from function property to support all mux functions
> >
> > Link to v1:https://lore.kernel.org/all/20260705132521.159522-1-challauday369@xxxxxxxxx/
> > ---
> > .../pinctrl/microchip,pic32-pinctrl.txt | 60 ----------
> > .../pinctrl/microchip,pic32mzda-pinctrl.yaml | 109 ++++++++++++++++++
> > 2 files changed, 109 insertions(+), 60 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,pic32-pinctrl.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,pic32mzda-pinctrl.yaml
> >
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>
Thank you, Rob. This patch has 2 parts(dt-binding & dtsi changes).
Can you also please review dtsi changes?
https://lore.kernel.org/all/20260731174751.86819-1-challauday369@xxxxxxxxx/
Regards,
Udaya Kiran Challa