Re: [PATCH] i3c: dw: use COMMAND_PORT_TRANSFER_ARG instead of hardcoding

From: Frank Li

Date: Thu Aug 13 2026 - 16:40:41 EST


On Thu, Aug 13, 2026 at 12:42:25PM +0800, Jisheng Zhang wrote:
> Use the well defined COMMAND_PORT_TRANSFER_ARG macro instead of
> hardcoding '1'.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> drivers/i3c/master/dw-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 655693a2187e..6ba84a97765f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -876,7 +876,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
> goto rpm_out;
> }
> cmd = &xfer->cmds[0];
> - cmd->cmd_hi = 0x1;
> + cmd->cmd_hi = COMMAND_PORT_TRANSFER_ARG;
> cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |
> COMMAND_PORT_DEV_INDEX(pos) |
> COMMAND_PORT_CMD(I3C_CCC_ENTDAA) |
> --
> 2.51.0
>