Re: [PATCH v14 09/22] KVM: selftests: Expose functions to get default sregs values

Next message: Ridong Chen: "Re: [PATCH v3 0/4] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim"
Previous message: bot+bpf-ci: "Re: [PATCH bpf-next v3 1/2] bpf, riscv: Add BPF stack arguments support for RV64 JIT"
In reply to: Edgecombe, Rick P: "Re: [PATCH v14 09/22] KVM: selftests: Expose functions to get default sregs values"
Next in thread: Edgecombe, Rick P: "Re: [PATCH v14 09/22] KVM: selftests: Expose functions to get default sregs values"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Xiaoyao Li

Date: Thu Aug 13 2026 - 22:36:58 EST

On 8/14/2026 8:44 AM, Edgecombe, Rick P wrote:

On Wed, 2026-07-22 at 23:13 +0000, Lisa Wang wrote:

+#ifndef NUM_INTERRUPTS
+#define NUM_INTERRUPTS 256
+#endif
+

Is this necessary for this patch? I see why to extract
kvm_get_default_idt_limit() because now it's used twice. But why extract this
define too?

kvm_get_default_idt_limit() uses NUM_INTERRUPTS, and kvm_get_default_idt_limit() is extracted as a helper from .c file to .h file. Shouldn't the define of NUM_INTERRUPTS be moved together?