Re: [PATCH 09/15] pinctrl: qcom: Add Kuno pinctrl driver

[Hardeep Sharma]

On 8/10/2026 4:33 PM, Bartosz Golaszewski wrote:
> On Sun, 9 Aug 2026 09:27:08 +0200, Hardeep Sharma
> <hardeep.sharma@xxxxxxxxxxxxxxxx> said:
> > Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting
> > 110 GPIOs and their pin multiplexing, pin configuration and gpiolib
> > interface through the common pinctrl-msm driver.
> >
> > Signed-off-by: Hardeep Sharma <hardeep.sharma@xxxxxxxxxxxxxxxx>
> > ---
> > +
> ...
>
> > +static const struct pinfunction kuno_functions[] = {
> > +	MSM_PIN_FUNCTION(gpio),
> MSM_GPIO_PIN_FUNCTION() ?

Thanks for review.

Done in v2 : 
https://lore.kernel.org/all/20260814-kuno-soc-support-v2-0-3079794f0f73@xxxxxxxxxxxxxxxx/

Best Wishes
Hardeep Sharma

> > +	MSM_PIN_FUNCTION(audio_ref_clk),
> > +	MSM_PIN_FUNCTION(coex_uart),
> > +	MSM_PIN_FUNCTION(ebi2_lcd_a),
> > +	MSM_PIN_FUNCTION(ebi2_lcd_cs),
> > +	MSM_PIN_FUNCTION(ebi2_lcd_reset),
> > +	MSM_PIN_FUNCTION(ebi2_lcd_te),
> > +	MSM_PIN_FUNCTION(emac_mdc),
> > +	MSM_PIN_FUNCTION(emac_mdio),
> > +	MSM_PIN_FUNCTION(emac_pps_in),
> > +	MSM_PIN_FUNCTION(emac_ptp_aux),
> > +	MSM_PIN_FUNCTION(emac_ptp_pps),
> > +	MSM_PIN_FUNCTION(gcc_gp1_clk),
> > +	MSM_PIN_FUNCTION(gcc_gp2_clk),
> > +	MSM_PIN_FUNCTION(gcc_gp3_clk),
> > +	MSM_PIN_FUNCTION(mi2s0_data0),
> > +	MSM_PIN_FUNCTION(mi2s0_data1),
> > +	MSM_PIN_FUNCTION(mi2s0_sck),
> > +	MSM_PIN_FUNCTION(mi2s0_ws),
> > +	MSM_PIN_FUNCTION(mi2s1_data0),
> > +	MSM_PIN_FUNCTION(mi2s1_data1),
> > +	MSM_PIN_FUNCTION(mi2s1_sck),
> > +	MSM_PIN_FUNCTION(mi2s1_ws),
> > +	MSM_PIN_FUNCTION(mi2s_mclk),
> > +	MSM_PIN_FUNCTION(nav_gpio),
> Possibly here too?

This one not required.

Grepped the tree for peer TLMM drivers that expose a `nav_gpio`
function: all 10 use MSM_PIN_FUNCTION(nav_gpio, ...), none use
MSM_GPIO_PIN_FUNCTION. Kuno matches that convention.

Best Wishes

Hardeep Sharma

> > +	MSM_PIN_FUNCTION(pci_e_rst),
> > +	MSM_PIN_FUNCTION(pcie_clkreq_n),
> > +	MSM_PIN_FUNCTION(pll_bist_sync),
> > +	MSM_PIN_FUNCTION(pll_clk_aux),
> > +	MSM_PIN_FUNCTION(qdss_cti_trig0),
> > +	MSM_PIN_FUNCTION(qdss_cti_trig1),
> > +	MSM_PIN_FUNCTION(qdss_gpio_traceclk),
> > +	MSM_PIN_FUNCTION(qdss_gpio_tracectl),
> > +	MSM_PIN_FUNCTION(qup0_se0),
> > +	MSM_PIN_FUNCTION(qup0_se1),
> > +	MSM_PIN_FUNCTION(qup0_se2),
> > +	MSM_PIN_FUNCTION(qup0_se3_mira),
> > +	MSM_PIN_FUNCTION(qup0_se3_mirb),
> > +	MSM_PIN_FUNCTION(qup0_se4),
> > +	MSM_PIN_FUNCTION(sdc4_clk),
> > +	MSM_PIN_FUNCTION(sdc4_cmd),
> > +	MSM_PIN_FUNCTION(sdc4_data),
> > +	MSM_PIN_FUNCTION(sdc4_tb_trig),
> > +	MSM_PIN_FUNCTION(sgmii_phy_intr),
> > +	MSM_PIN_FUNCTION(spmi_coex_clk),
> > +	MSM_PIN_FUNCTION(spmi_coex_data),
> > +	MSM_PIN_FUNCTION(spmi_vgi_hwevent),
> > +	MSM_PIN_FUNCTION(uim1_clk),
> > +	MSM_PIN_FUNCTION(uim1_data),
> > +	MSM_PIN_FUNCTION(uim1_present),
> > +	MSM_PIN_FUNCTION(uim1_reset),
> > +	MSM_PIN_FUNCTION(usb2phy_ac_en),
> > +};
> > +
> Bart