Re: [PATCH v1 1/4] iio: light: Unshadow error codes in ->store()

[Joshua Crofts]

On Fri, 14 Aug 2026 at 10:16, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Aug 13, 2026 at 09:47:00PM -0500, Maxwell Doose wrote:
> > On Thu Aug 13, 2026 at 3:47 PM CDT
> > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > > On Thu, Aug 13, 2026 at 8:52 PM Maxwell Doose <maxwell@xxxxxxxxxxx> wrote:
>
> ...
>
> > > Note, that kernel.h shouldn't be there at all, but that is definitely out
> > > of scope here.
> >
> > Makes sense. I wonder if it may be worth doing a patch series removing
> > all of the kernel.h inclusions in IIO all at once (or maybe some drivers
> > have a legitimate use for it, but that seems highly unlikely).
>
> Yes, for sure! I have simply had no time to do it myself, but I have a low-prio
> item in my always grown TODO list. So, if you do that, I will really appreciate!
> But be careful, the actual patches should care about the whole bunch of the
> inclusions, and not just about kernel.h. This means each driver should be
> carefully inspected in accordance with the IWYU principles.

This will be a gruelling task (implementing and reviewing), but perhaps it
would be easier to do one sensor type at a time instead of the entire
subsystem.

--
Kind regards,
Joshua Crofts