Re: [PATCH v3] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode
From: Krzysztof Kozlowski
Date: Fri Aug 14 2026 - 05:11:17 EST
On Thu, Aug 13, 2026 at 04:55:54PM +0530, Vishnu Santhosh wrote:
> Allow an optional bam-dmux subnode under qcom,shikra-mpss-pas by
> referencing qcom,bam-dmux.yaml.
I still miss the answer why. Last time you said in present tense that
this node exists there, which I objected. The answer to my objections is
to provide proper reason why you are adding this, why you are doing it.
Answer almost never is: repeat what the diff is doing.
You change something in the bindings because something exists in the
hardware and it was missed in initial submission, and you explain the
impact of that "missing".
Best regards,
Krzysztof