Re: [PATCH v4 2/3] usb: typec: tipd: Factor out i2c specifics

[Heikki Krogerus]

Hi,

On Thu, Aug 06, 2026 at 11:37:21AM +0200, Sasha Finkelstein wrote:
> From: Alyssa Milburn <amilburn@xxxxxxxx>
> 
> Make the core driver more bus-agnostic to prepare for SPMI variants of
> the tipd chip
> 
> Signed-off-by: Alyssa Milburn <amilburn@xxxxxxxx>
> Signed-off-by: Sasha Finkelstein <k@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/typec/tipd/Kconfig    |   8 ++++--
>  drivers/usb/typec/tipd/Makefile   |  11 ++++---
>  drivers/usb/typec/tipd/core.c     | 225 +++++++++++++++++++++++------------------------------------------------------------------------------------------------------------------------
>  drivers/usb/typec/tipd/i2c.c      | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/typec/tipd/tps6598x.h | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 276 insertions(+), 195 deletions(-)

I kept you wating so long that this does not apply on top of Greg's
usb-next any more. I'm sorry about that. But since you need to resend
in any case, one more nitpick/question. With that, for both patches:

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> +int tipd_init(struct tps6598x *tps);

How about:

        int tipd_init(struct tps6598x *tps, enum tipd_hw_variant variant);

Thanks,

-- 
heikki