Re: [PATCH] crypto: stm32/hash: fix autosuspend cleanup during teardown

[Maxime MERE]

On 8/8/26 11:41, Guangshuo Li wrote:
> stm32_hash_probe() calls pm_runtime_use_autosuspend(), but neither the
> probe failure path nor stm32_hash_remove() calls the matching
> pm_runtime_dont_use_autosuspend() before disabling runtime PM.
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during teardown, this reference is not dropped and usage_count remains
> unbalanced.
>
> Add the missing pm_runtime_dont_use_autosuspend() calls to both the
> probe failure and remove paths before disabling runtime PM.
>
> This issue was found by manual code inspection.
>
> Fixes: 8b4d566de6a5 ("crypto: stm32/hash - Add power management support")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
Reviewed-by: Maxime Méré <maxime.mere@xxxxxxxxxxx>

Cheers,

Maxime