Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver

[Alex Elder]

On 8/13/26 8:11 PM, Greg KH wrote:
> On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote:
> > +#define DRIVER_NAME "tc9564-pci"
>
> What about just using KBUILD_MODNAME?

Yes, I'll use that.  The underscore versus dash doesn't
matter...
> > +static int
> > +tc9564_function_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> But wow, this is a tiny driver, feels odd to have it in misc/ but ok, if
> you think it should be here...

I put it in misc/ because lan966xc_pci.c, which also uses
a pci-ep-bus, is located there.  That driver also calls
of_platform_default_populate(), though it also loads a
DT overlay which isn't needed here.

It is indeed tiny, and your comment makes me think it
could easily become a generic driver (along the lines
of "simple-mfd-i2c.c").  That way other similar future
SoCs could just add their compatible string.

So two questions (for anyone):
- Would that be preferred--rename this to target a generic
  situation?  For example, "static-pci-ep-bus.c"?
- Where should such a driver be located?  For example,
  drivers/misc/, drivers/pci/controller/, or something else?

					-Alex

> thanks,
>
> greg k-h