Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver
From: Alex Elder
Date: Fri Aug 14 2026 - 12:58:19 EST
On 8/14/26 2:03 AM, Krzysztof Kozlowski wrote:
On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote:
+static struct pci_driver tc9564_function_driver = {
+ .name = DRIVER_NAME,
+ .id_table = tc9564_function_id_table,
+ .probe = tc9564_function_probe,
+ .remove = tc9564_function_remove,
+ .driver = {
+ .name = DRIVER_NAME,
+ .owner = THIS_MODULE,
You just copied some old driver. Why do you need this?
What do you mean I "just copied some old driver"?
I do now see that a PCI driver doesn't need to set it,
because pci_register_driver() sets it automatically.
I will remove that in the next version.
-Alex>
+ },
+};
+module_pci_driver(tc9564_function_driver);
+
+MODULE_DESCRIPTION("Toshiba TC9564 PCIe Embedded Function Driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 6501c949c5b76..b484f1b1d0e71 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -6388,6 +6388,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5020, of_pci_make_dev_node);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5021, of_pci_make_dev_node);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REDHAT, 0x0005, of_pci_make_dev_node);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_EFAR, 0x9660, of_pci_make_dev_node);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_TOSHIBA, 0x0220, of_pci_make_dev_node);
/*
* Devices known to require a longer delay before first config space access
--
2.53.0