Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible

From: Rob Herring

Date: Fri Aug 14 2026 - 13:56:44 EST


On Fri, Aug 14, 2026 at 06:18:55AM +0000, Esben Haabendal wrote:
> On Monday, August 10th, 2026 at 17:50, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > On Mon, Aug 10, 2026 at 09:11:13AM +0200, Esben Haabendal wrote:
> > > LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> > > without interrupt support.
> > >
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > > Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
> > > ---
> > > Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > sashiko issue should be addressed.
>
> What about the suggestion about adding `proximity-near-level: false` to the condition. I am thinking something like this is more correct
>
> properties:
> proximity-near-level: false
>
> allOf:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - liteon,ltr501
> - liteon,ltr559
> then:
> properties:
> proximity-near-level: true

That does not work. The if/then can only add restrictions, not relax
them. It can do allowed->not-allowed, but not vice-versa as you have.

Rob