Re: [PATCH v10 18/41] KVM: TDX: Make source page optional for KVM_TDX_INIT_MEM_REGION
From: Sean Christopherson
Date: Fri Aug 14 2026 - 13:58:05 EST
On Fri, Aug 14, 2026, Binbin Wu wrote:
> On 8/8/2026 5:52 AM, Ackerley Tng via B4 Relay wrote:
> > From: Ackerley Tng <ackerleytng@xxxxxxxxxx>
> >
> > Update tdx_gmem_post_populate() to handle cases where userspace requests
> > "no source page". To handle "no source page", populate (perform
> > TDH.MEM.PAGE.ADD) using memory in-place at the target PFN.
> >
> > Allow "no source page" only when gmem_in_place_conversion is enabled,
> > because retroactively adding support for out-of-place conversion would mean
> > requiring a userspace update for a feature that's being deprecated.
> >
> > Also, KVM supporting "no source page" without in-place conversion would
> > effectively be an obscure zero-page optimization that relies on the page
> > being zeroed when it is allocated by guest_memfd.
> >
> > Rejecting "no source page" without in-place conversion scenario is valuable
> > for KVM developers since it helps newcomers understand what exactly is and
> > isn't possible.
> >
> > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
>
> Nit:
> Is Sean's SoB intentional here?
Kinda sorta? I handed commits to Ackerley after rebasing them locally at one
point, which is how my SoB got here. I think it makes sense to just drop them
from the patches where I'm not listed as the author or Co-developed-by. In the
end, I expect to apply this series and so my SoB will get added backon anyways.