Re: [PATCH 0/3] selftests/mm: TAP output and global-state fixes

From: Song Hu

Date: Sat Aug 15 2026 - 02:42:01 EST


Hi, Andrew

在 2026/8/13 04:51, Andrew Morton 写道:
> On Wed, 12 Aug 2026 20:08:18 +0800 Song Hu <husong@xxxxxxxxxx> wrote:
>
>> uffd-wp-mremap and mremap_test never print the TAP header (and mremap_test
>> skips with a bare exit(KSFT_SKIP) rather than a KTAP skip), so their output
>> is not valid KTAP; hugetlb-soft-offline toggles enable_soft_offline during
>> the run and leaves it disabled afterwards.
>
> Thanks. AI review found a couple of minor error-path issues, both of
> which look legitimate to me.
> https://sashiko.dev/#/patchset/20260812120821.523860-1-husong@xxxxxxxxxx

Agreed, both will be fixed in v2:

- hugetlb-soft-offline: restore via atexit() so it also runs on
ksft_exit_fail_msg() exits, and use read_num()/write_num() per Mike's
comment.

- mremap_test: save errno before fclose() in get_mmap_min_addr().

Thanks,
Song