Re: [PATCH 1/3] iio: imu: adis16480: fix unprotected debugfs reads

From: Andy Shevchenko

Date: Sat Aug 15 2026 - 04:47:45 EST


On Fri, Aug 14, 2026 at 06:07:26PM +0900, Arka Mondal wrote:
> The firmware_revision and firmware_date file operations are open coded
> and never call debugfs_file_get(), which debugfs_create_file_unsafe()
> requires. debugfs_remove_recursive() therefore does not wait for a read
> in progress, and unbind frees the iio_dev underneath it.
>
> Use debugfs_create_file() instead.

This one looks correct, but would it be possible to switch to use
DEFINE_DEBUGFS_ATTRIBUTE() instead?

In case Jonathan wants to apply this
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

Also whenever send a series, add cover letter to it. Your patch preparing
should be like

git format-patch --cover-letter --base ... -v <n> ...

where <n> is patch series version number.

--
With Best Regards,
Andy Shevchenko