Re: [PATCH] platform/x86: Add Goodix fingerprint EC mailbox transport

[kernel test robot]

Hi Ertuğrul,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v7.2-rc7 next-20260814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ertu-rul-Top-u/platform-x86-Add-Goodix-fingerprint-EC-mailbox-transport/20260815-121223
base:   linus/master
patch link:    https://lore.kernel.org/r/20260727205837.91413-1-ertugtopcu0%40gmail.com
patch subject: [PATCH] platform/x86: Add Goodix fingerprint EC mailbox transport
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260816/202608160824.RMzAY05S-lkp@xxxxxxxxx/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260816/202608160824.RMzAY05S-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608160824.RMzAY05S-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/platform/x86/goodix-ec-mailbox/goodix_ec_main.c: In function 'goodix_ec_mmio_write_tx':
>> drivers/platform/x86/goodix-ec-mailbox/goodix_ec_main.c:204:17: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Wimplicit-function-declaration]
     204 |                 writeq(value, gdev->mailbox + GOODIX_EC_TX_OFFSET + offset);
         |                 ^~~~~~
         |                 writel
   drivers/platform/x86/goodix-ec-mailbox/goodix_ec_main.c: In function 'goodix_ec_mmio_read_rx':
>> drivers/platform/x86/goodix-ec-mailbox/goodix_ec_main.c:216:29: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
     216 |                 u64 value = readq(gdev->mailbox + GOODIX_EC_RX_OFFSET + offset);
         |                             ^~~~~
         |                             readl


vim +204 drivers/platform/x86/goodix-ec-mailbox/goodix_ec_main.c

   196	
   197	static void goodix_ec_mmio_write_tx(struct goodix_device *gdev, size_t len)
   198	{
   199		size_t offset;
   200	
   201		for (offset = 0; offset < len; offset += sizeof(u64)) {
   202			u64 value = get_unaligned_le64(gdev->tx_buf + offset);
   203	
 > 204			writeq(value, gdev->mailbox + GOODIX_EC_TX_OFFSET + offset);
   205		}
   206	
   207		/* Publish every qword before asserting the write-done doorbell. */
   208		wmb();
   209	}
   210	
   211	static void goodix_ec_mmio_read_rx(struct goodix_device *gdev)
   212	{
   213		size_t offset;
   214	
   215		for (offset = 0; offset < GOODIX_EC_RX_SIZE; offset += sizeof(u64)) {
 > 216			u64 value = readq(gdev->mailbox + GOODIX_EC_RX_OFFSET + offset);
   217	
   218			put_unaligned_le64(value, gdev->rx_buf + offset);
   219		}
   220	
   221		/* Complete the mailbox snapshot before parsing its headers. */
   222		rmb();
   223	}
   224	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki