Re: [PATCH v2] usbip: vhci_hcd: let the driver core manage the sysfs attributes

From: Greg KH

Date: Sun Aug 16 2026 - 02:58:34 EST


On Sun, Aug 16, 2026 at 11:41:41AM +0530, Deepanshu Kartikey wrote:
> On Sun, Aug 16, 2026 at 10:26 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
>
> > > extern struct vhci *vhcis;
> > > extern struct attribute_group vhci_attr_group;
> >
> > Is this still needed here? And can't it be static now?
> >
> > > @@ -1565,9 +1546,12 @@ static int __init vhci_hcd_init(void)
> > >
> > > return 0;
> > >
> > > +
> >
> > Extra line?
> >
> > thanks,
> >
> > greg k-h
>
> I have sent patch v3

Please slow down, there is no rush here, you shouldn't be sending
patches more than one every few days.

greg k-h