Re: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS

[Julian Braha]

On 8/16/26 22:11, Rosen Penev wrote:
> On Sat, Aug 15, 2026 at 5:01 PM Julian Braha <julianbraha@xxxxxxxxx> wrote:
>>
>> Hi Rosen,
>>
>> On 8/2/26 22:14, Rosen Penev wrote:
>>> On Sun, Aug 2, 2026 at 7:49 AM Julian Braha <julianbraha@xxxxxxxxx> wrote:
>>>>
>>>> SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select
>>>> SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is
>>>> met. This causes unmet dependencies such as:
>>>>
>>>> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
>>>>   Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n]
>>>>   Selected by [m]:
>>>>   - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
>>>>
>>>> SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its
>>>> dependency on SND_SOC_AC97_BUS is met.
>>>>
>>>> Let's resolve all 3 unmet dependencies by adding the dependencies on
>>>> PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar
>>>> options in this subsystem do.
>>>>
>>>> These unmet dependency bugs were detected by kconfirm, a static analysis tool
>>>> for Kconfig.
>>>>
>>>> Fixes: a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
>>>> Fixes: 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
>>>> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
>>>> ---
>>>>  sound/soc/fsl/Kconfig | 4 +++-
>>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
>>>> index 8ae59c094878..a5d7cf534391 100644
>>>> --- a/sound/soc/fsl/Kconfig
>>>> +++ b/sound/soc/fsl/Kconfig
>>>> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>>>>
>>>>  config SND_MPC52xx_SOC_PCM030
>>>>         tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
>>>> -       depends on PPC_MPC5200_SIMPLE
>>>> +       depends on PPC_BESTCOMM
>>>>         select SND_SOC_MPC5200_AC97
>>>>         select SND_SOC_WM9712
>>>>         help
>>>> @@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
>>>>  config SND_MPC52xx_SOC_EFIKA
>>>>         tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
>>>>         depends on PPC_EFIKA
>>>> +       depends on PPC_BESTCOMM
>>> does this really depend on PPC_BESTCOMM?
>>
>> Yes, BestComm is the co-processor found on Freescale MPC5200.
> Just took a look at this.
> 
> --- a/sound/soc/fsl/efika-audio-fabric.c
> +++ b/sound/soc/fsl/efika-audio-fabric.c
> @@ -22,8 +22,6 @@
>  #include <sound/initval.h>
>  #include <sound/soc.h>
> 
> -#include "mpc5200_dma.h"
> -
>  #define DRV_NAME "efika-audio-fabric"
> 
>  SND_SOC_DAILINK_DEFS(analog,
> 
> compiles. That header indeed references bestcom stuff, but I don't see
> the driver doing so.
>>
>> - Julian Braha

Ahh, nice catch! I'll send a v2 soon.

- Julian Braha