Re: [PATCH 03/12] iio: adc: rohm-bd79124: Fix GPIO mask check

From: Jonathan Cameron

Date: Sun Aug 16 2026 - 21:24:13 EST


On Mon, 10 Aug 2026 10:50:49 +0300
Matti Vaittinen <matti.vaittinen@xxxxxxxxx> wrote:

> From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
>
> The ROHM BD79124 has pins which can be configured as GPOs or as ADC
> inputs. The bd79124gpo_set_multiple() is intended to ensure that a pin
> which is requested to be toggled, is indeed configured as a GPO.
>
> The check uses XOR, causing it to fail if mask is not exactly same as
> GPO configuration. Eg, if not all GPOs are asked to be toggled at once.
>
> Fix this by checking that mask does not contain pins that are not
> configured as GPO, allowing some of the pins which are configured as
> GPO to be untouched.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Fixes: 3f57a3b9ab74 ("iio: adc: Support ROHM BD79124 ADC")
Applied and marked for stable.