Re: [PATCH v3] mm/rmap: synchronize lock and unlock target in anon_vma_clone

[Barry Song]

On Mon, Aug 17, 2026 at 11:58 AM Eric Kim <seohyun.kim@xxxxxxxxxx> wrote:
>
> Currently, in anon_vma_clone(), active_anon_vma is assigned from
> src->anon_vma and is used when unlocking anon_vma after linking
> new AVCs. However, the corresponding lock operation uses
> src->anon_vma directly.
>
> Use active_anon_vma consistently to make the lock/unlock pair explicit.

Thanks! Could we add something along these lines?

Although they are actually the same thing, use active_anon_vma
consistently to make the lock/unlock pair explicit.

>
> Signed-off-by: Eric Kim <seohyun.kim@xxxxxxxxxx>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> Reviewed-by: Lance Yang <lance.yang@xxxxxxxxx>
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>
> ---

With that,

Reviewed-by: Barry Song <baohua@xxxxxxxxxx>