Re: [PATCH v6] ptp: ocp: add CPLD ISP support for ADVA TimeCard X1

From: Philip Li

Date: Mon Aug 17 2026 - 01:25:19 EST

On Sun, Aug 16, 2026 at 09:02:37AM +0300, Sagi Maimon wrote:
> On Sun, Aug 16, 2026 at 1:54 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> >
> > Hi Sagi,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on net-next/main]
> > [also build test WARNING on net/main linus/master v7.2-rc7 next-20260814]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Sagi-Maimon/ptp-ocp-add-CPLD-ISP-support-for-ADVA-TimeCard-X1/20260813-075719
> > base: net-next/main
> > patch link: https://lore.kernel.org/r/20260723143908.4019-1-maimon.sagi%40gmail.com
> > patch subject: [PATCH v6] ptp: ocp: add CPLD ISP support for ADVA TimeCard X1
> > compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
> > docutils: docutils (Docutils 0.21.2, Python 3.13.5, on linux)
> > reproduce: (https://download.01.org/0day-ci/archive/20260816/202608160048.0KcqzO98-lkp@xxxxxxxxx/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202608160048.0KcqzO98-lkp@xxxxxxxxx/
> >
> > All warnings (new ones prefixed by >>):
> >
> > WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode is defined 2 times: Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:364; Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:234
> > WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode_index is defined 2 times: Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:373; Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:243
> > WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled is defined 2 times: Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:636; Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:252
> > WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled_index is defined 2 times: Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:645; Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:261
> > Documentation/ABI/testing/sysfs-timecard:14: ERROR: Unexpected indentation. [docutils]
> > >> Documentation/ABI/testing/sysfs-timecard:14: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> > Documentation/ABI/testing/sysfs-timecard:14: ERROR: Unexpected indentation. [docutils]
> > WARNING: ./block/blk-map.c:366 Excess function parameter 'op' description in 'bio_copy_kern'
> > Documentation/driver-api/basics:42: ./kernel/time/time.c:370: WARNING: Duplicate C declaration, also defined at driver-api/basics:436.
> > Declaration is '.. c:function:: unsigned int jiffies_to_msecs (const unsigned long j)'. [duplicate_declaration.c]
> > Documentation/driver-api/basics:42: ./kernel/time/time.c:393: WARNING: Duplicate C declaration, also defined at driver-api/basics:453.
> >
> >
> > vim +14 Documentation/ABI/testing/sysfs-timecard
> >
> > > 14 What: /sys/class/timecard/ocpN/cpld_i2c_xfer
> > 15 Date: July 2026
> > 16 Contact: Sagi Maimon <sagi.maimon@xxxxxxxx>
> > 17 Description: (RW) Binary sysfs attribute providing a raw I2C passthrough to
> > 18 the CPLD and I2C mux on ADVA x1 TAP boards. Only present on
> > 19 that board variant.
> > 20
> > 21 Each write initiates one I2C transaction. The write payload
> > 22 must be exactly four header bytes followed by the write data:
> > 23
> > 24 Byte 0: slave address (only 0x40 and 0x74 are permitted)
> > 25 Byte 1: number of bytes to write (0..67)
> > 26 Byte 2: number of bytes to read back (0..20)
> > 27 Byte 3: flags
> > 28 bit 0 - suppress the repeated START before the
> > 29 read segment (I2C_M_NOSTART); only valid
> > 30 when both write and read lengths are
> > 31 non-zero
> > 32 Bytes 4..: write data (write_len bytes)
> > 33
> > 34 A subsequent read() returns:
> > 35
> > 36 Byte 0: status (0 = success, positive errno on error)
> > 37 Bytes 1..: read data (read_len bytes), present only when
> > 38 status is 0 and read_len > 0
> > 39
> > 40 The write and read portions of the sysfs file share a single
> > 41 per-device response buffer protected by a mutex; a single
> > 42 open() / write() / read() sequence must be used to avoid
> > 43 data races between concurrent users.
> > 44
> > 45 Only slave addresses 0x40 (Lattice CPLD) and 0x74 (PCA9548
> > 46 I2C mux) are accepted; all others return EPERM.
> > 47
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> This report is against v6 (20260723143908.4019-1-maimon.sagi@xxxxxxxxx).
> The cpld_i2c_xfer attribute it flags was dropped after that revision; the
> current posting is v11:
>
> https://lore.kernel.org/netdev/20260811135720.109580-1-maimon.sagi@xxxxxxxxx/
>
> I checked v11's sysfs-timecard through the ABI parser and docutils - no
> indentation warnings.

Thanks for the info and sorry for this meaningless report. I will fix the
bot logic to avoid such report.

>