Re: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8
From: Dan Carpenter
Date: Mon Aug 17 2026 - 03:49:52 EST
On Sat, Aug 15, 2026 at 01:10:30PM -0600, Ivy Lopez wrote:
> EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE
> (254) but is only ever assigned into s8 (signed char) fields used
> to store signed TX power calibration offsets. The implicit
> truncation to -2 is intentional.
Just change it to:
#define EEPROM_DEFAULT_DIFF -2
regards,
dan carpenter