Re: [PATCH 2/2] dt-bindings: clock: Add GCC clock bindings for SM7250

From: Krzysztof Kozlowski

Date: Mon Aug 17 2026 - 04:09:24 EST


On 16/08/2026 11:07, Sreeshankar K wrote:
> Add device tree bindings for global clock controller on SM7250 SoC.
>
> Signed-off-by: Sreeshankar K <sreeshankar0910@xxxxxxxxx>

Please start using b4. Does this work:

b4 diff '<20260816090719.892-3-sreeshankar0910@xxxxxxxxx>'

? No.



> ---
> .../bindings/clock/qcom,gcc-sm7250.yaml | 60 +++++++
> include/dt-bindings/clock/qcom,gcc-sm7250.h | 163 ++++++++++++++++++
> 2 files changed, 223 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sm7250.yaml
> create mode 100644 include/dt-bindings/clock/qcom,gcc-sm7250.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm7250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm7250.yaml
> new file mode 100644
> index 000000000..822df7dc1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm7250.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-sm7250.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller on SM7250
> +
> +maintainers:
> + - Bjorn Andersson <andersson@xxxxxxxxxx>
> + - Sreeshankar K <sreeshankar0910@xxxxxxxxx>
> +
> +description: |
> + Qualcomm global clock control module provides the clocks, resets and power
> + domains on SM7250.
> +
> + See also: include/dt-bindings/clock/qcom,gcc-sm7250.h
> +
> +properties:
> + compatible:
> + const: qcom,gcc-sm7250
> +
> + clocks:
> + items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source

Why this cannot go to sm7150 or sm6375 files?

Best regards,
Krzysztof