Re: [PATCH net-next v2 1/4] of: property: skip links without a consumer node

From: Andrew Lunn

Date: Mon Aug 17 2026 - 08:58:04 EST


On Sun, Aug 16, 2026 at 10:07:19PM -0700, Saravana Kannan wrote:
> On Sun, Aug 16, 2026 at 5:00 PM James Hilliard
> <james.hilliard1@xxxxxxxxx> wrote:
> >
> > Supplier bindings can map a property node to the device node which
> > consumes the referenced resource. The remote-endpoint binding uses
> > of_graph_get_port_parent(), which can return NULL for a malformed graph
> > node without its expected parents.

If it is malformed, do we care? An Opps is a good way to indicate
there is something wrong, and it contains more information than a
-EINVAL.

> > Only create the link when the binding resolved a consumer node. A
> > malformed graph property then creates no dependency instead of crashing
> > while fw_devlink parses the tree.
>
> Is this a real issue? If it's upstream, should we fix the DT? If it's
> off-tree/down stream, should we care?

Good questions.

Andrew