Re: [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

From: Rob Herring (Arm)

Date: Mon Aug 17 2026 - 09:29:17 EST



On Sun, 16 Aug 2026 00:23:00 +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments Keystone Device State Control binding from
> legacy text format to DT schema.
>
> During the conversion, the following updates were made:
> - Add "simple-mfd" to compatibles matching existing dts usage.
> - Add required bus properties #address-cells, #size-cells, and ranges
> which were missing in text binding.
> - Document child nodes gpio, interrupt-controller, and reset-controller.
>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
> ---
> Note: Running dt_binding_check on patch will yield a warning for
> 'ti,keystone-reset' in the example block. The YAML conversion patch for
> that child node is already in progress here:
> https://lore.kernel.org/linux-devicetree/20260813-ti-keystone-reset-v1-1-189389503324@xxxxxxxxx/
> ---
> .../bindings/mfd/ti,keystone-devctrl.yaml | 84 ++++++++++++++++++++++
> .../bindings/mfd/ti-keystone-devctrl.txt | 19 -----
> 2 files changed, 84 insertions(+), 19 deletions(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: /example-0/device-state-control@2620000/reset-controller@328: failed to match any schema with compatible: ['ti,keystone-reset']
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: reset-controller@328 (ti,keystone-reset): ti,syscon-pll: b'\xff\xff\xff\xff\x00\x00\x00\xe4' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: reset-controller@328 (ti,keystone-reset): ti,wdt-list: b'\x00\x00\x00\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260816-ti-keystone-devctrl-v2-2-5ab1e13c15c1@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.