Re: [PATCH v2 3/4] sysctl: Disallow partial updates for erroneous sysctl vectors

[Bradley Morgan]

On 17 August 2026 14:43:44 BST, Joel Granados <joel.granados@xxxxxxxxxx>
wrote:
>On Sat, Aug 15, 2026 at 05:05:26PM +0100, Bradley Morgan wrote:
>> commit_conv_vec() writes the elements one by one, so a reader can
>> still see a mix of old and new values while the loop runs. Same as
>> before this series, so no regression, but the changelog could say
>> this doesn't make the write atomic either. Otherwise someone later
>> will expect the vector to change all at once.
>
>Seems reasonable: here is what I added to the commit message:
>
>
>"
>... This (The staging vector) does **not** make the write atomic as a
>reader
>can still see a partially updated vector.
>

Good enough.


>...
>"
>
>Best
>
>Joel
>
>> 
>> The copy is limited by table->maxlen and only vectors pay for it.
>> 
>> Fine by me.
>> 
>> Reviewed-by: Bradley Morgan <include@xxxxxxxxx>
>> Thanks!
>

Thanks!