Re: [PATCH net-next v7 03/14] ax88179_178a: Split driver into library and device specific code

[Jakub Kicinski]

On Mon, 10 Aug 2026 14:33:28 +0200 Birger Koblitz wrote:
> +static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
> +			       u16 size, const void *data)

Local netdev convention is to still wrap at 80 chars.
Anything beyond that is inviting laziness.

> +{
> +	int ret;
> +	int (*fn)(struct usbnet *dev, u8 cmd, u8 rtype, u16 val, u16 i, const void *d, u16 size);
> +	struct ax88179_data *ax179_data = dev->driver_priv;

Local netdev convention - please sort the variable declaration lines
longest to shortest

> +	if (!dev) {
> +		netdev_err(dev->net, "No net device.\n");
> +		return -ENODEV;
> +	}

Is this a real check you need? It was a BUG() previously, so clearly
it must never happen. Please don't add pointless defensive checks.