Re: [PATCH v10 13/17] fs/resctrl: Call architecture hooks for every mount/unmount

[Reinette Chatre]

Hi Tony,

On 7/29/26 10:27 AM, Tony Luck wrote:
>  static int rdt_get_tree(struct fs_context *fc)
> @@ -3175,9 +3176,11 @@ static int rdt_get_tree(struct fs_context *fc)
>  	struct kernfs_node *rdt_root_kn;
>  	struct rdt_l3_mon_domain *dom;
>  	struct rdt_resource *r;
> +	bool cleanup = true;
>  	int ret;
>  
> -	DO_ONCE_SLEEPABLE(resctrl_arch_pre_mount);
> +	if (resctrl_arch_pre_mount() == -EBUSY)
> +		return -EBUSY;
>  
This does not look right. Are you intending to add new meanings to EBUSY returned
by resctrl so that user space now need to choose between "resctrl fs is already mounted"
and "the underlying architecture is busy with something else"? Based on the implementation
the architecture could now also return EBUSY when resctrl fs is mounted, but what prevents
an architecture from returning EBUSY in some other scenario? This error code to user space
does not seem like a responsibility that the architecture code needs to have.

Reinette