Re: [PATCH v4 2/6] iio: dac: ad5504: Align headers with IWYU principle
From: Andy Shevchenko
Date: Tue Aug 18 2026 - 00:43:56 EST
On Mon, Aug 17, 2026 at 05:11:11PM -0400, Taha Ed-Dafili wrote:
> Update the header inclusions to follow the IWYU principle and ensure
> they are sorted alphabetically:
>
> - Remove <linux/fs.h>, <linux/slab.h>, and <linux/kernel.h> as they
> are unused. The driver relies on devm_ managed allocations, so slab
> is not required.
> - Replace <linux/bitops.h> with <linux/bits.h> as only the BIT() and
> GENMASK() macros are used.
> - Add <linux/mod_devicetable.h> for struct spi_device_id.
Not anymore, now spi.h is responsible for that.
> - Add <linux/errno.h> and <linux/types.h> for error codes and data types.
> - Add <asm/byteorder.h> for cpu_to_be16().
> - Add <linux/array_size.h> for ARRAY_SIZE().
> - Add <linux/kstrtox.h> for string to integer conversions.
> - Replaced <linux/device.h> with <linux/dev_printk.h>
--
With Best Regards,
Andy Shevchenko