Re: [PATCH v24 04/12] mfd: psci-mfd: Add PSCI MFD driver for cpuidle-psci-domain cell

[Shivendra Pratap]

On 8/13/2026 6:36 PM, Bartosz Golaszewski wrote:
> On Thu, 13 Aug 2026 14:38:41 +0200, Lee Jones <lee@xxxxxxxxxx> said:
> > On Mon, 03 Aug 2026, Shivendra Pratap wrote:
> >
> > > PSCI has multiple kernel consumers, such as cpuidle-psci-domain.
> > > Currently, both the PSCI core driver and cpuidle-psci-domain bind
> > > directly to the same PSCI node "arm,psci-1.0". Additional consumers, if
> > > introduced, would also need to bind in the same way, leading to several
> > > drivers attached to a single device node.
> > >
> > > Introduce a PSCI MFD driver that binds to "arm,psci-1.0" and registers
> > > PSCI child cells. As the first user, register cpuidle-psci-domain as a
> > > child cell.
> > >
> > > Update cpuidle-psci-domain to probe as an MFD child and use the parent
> > > PSCI node for power-domain traversal.
> > >
> > > Suggested-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Shivendra Pratap <shivendra.pratap@xxxxxxxxxxxxxxxx>
> > > ---
> > >   MAINTAINERS                           |  1 +
> > >   drivers/cpuidle/Kconfig.arm           |  1 +
> > >   drivers/cpuidle/cpuidle-psci-domain.c |  9 +-------
> > >   drivers/mfd/Kconfig                   | 12 ++++++++++
> > >   drivers/mfd/Makefile                  |  2 ++
> > >   drivers/mfd/psci-mfd.c                | 43 +++++++++++++++++++++++++++++++++++
> >
> > We don't usually allow the use of the term MFD in devices.
> >
> > What does this do?  Is it a mux?  psci-mux?
> >
> > If not, think about what it is and call it that instead.
>
> My two cents: I'd call it drivers/mfd/arm-psci.c

Ack.

thanks,
Shivendra