Re: [PATCH v2 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer

[Krzysztof Kozlowski]

On Thu, Aug 13, 2026 at 02:26:10PM +0200, Kanak Shilledar wrote:
> ICM42370P is a 3-axis accelerometer. The device can support I2C, SPI
> and I3C. Add the supporting devicetree documentation for I2C as we
> have only tested using I2C protocol and leave the reset for future

"rest"?

> work.
> 
> The device supports VDD and VDDIO operating range of 1.71V to 3.6V.
> 
> Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> ---
>  .../bindings/iio/accel/invensense,icm42370p.yaml   | 84 ++++++++++++++++++++++
>  MAINTAINERS                                        |  8 +++
>  2 files changed, 92 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml
> new file mode 100644
> index 0000000000000..df23406921a51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/invensense,icm42370p.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICM-42370-P Accelerometer
> +
> +maintainers:
> +  - Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> +  - Henrik Grimler <henrik.grimler@xxxxxxxx>
> +
> +description: |
> +  3-axis accelerometer MotionTracking device.
> +
> +  It supports I3C, I2C and SPI serial communication, has a 2.25kB FIFO
> +  and 2 programmable interrupts with low-power wake-on-motion support.
> +
> +  It also has programmable filters and an embedded temperature sensor.
> +
> +  https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
> +
> +properties:
> +  compatible:
> +    const: invensense,icm42370p
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 2
> +
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      enum:
> +        - INT1
> +        - INT2
> +
> +  drive-open-drain:
> +    type: boolean
> +    description:
> +      Whether irq is in open-drain mode. False means push-pull mode.
> +
> +  mount-matrix: true
> +
> +  vdd-supply:
> +    description: Regulator operating range between 1.71V to 3.6V.
> +
> +  vddio-supply:
> +    description: Regulator operating range between 1.71V to 3.6V.
> +
> +dependencies:
> +  interrupt-names: [ interrupts ]

Drop, core schema has it. Unless you wanted the interrupts to require
names, so opposite dependency? See other bindings how this is done.


> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply
> +  - vddio-supply
> +
> +unevaluatedProperties: false

additionalProps, see other bindings.

But OTOH, if this is SPI device then where is spi-peripheral-props
reference (and then unevaluatedProps woyld be correct), regardless if
you tested drivers or not.

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        accelerometer@69 {
> +            compatible = "invensense,icm42370p";
> +            reg = <0x69>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> +            interrupt-names = "INT1";
> +            vdd-supply = <&vdd>;
> +            vddio-supply = <&vddio>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 04fa5322d9f74..e4764489ea971 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13561,6 +13561,14 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml
>  F:	drivers/media/i2c/isl7998x.c
>  
> +INVENSENSE ICM-42370-P ACCELEROMETER
> +M:	Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> +M:	Henrik Grimler <henrik.grimler@xxxxxxxx>
> +L:	kernel@xxxxxxxx
> +S:	Maintained
> +W:	https://invensense.tdk.com/

Let's drop the website? No need to repeat it for every driver.


> +F:	Documentation/devicetree/bindings/iio/accel/invensense,icm42370p.yaml
> +
>  INVENSENSE ICM-426xx IMU DRIVER
>  M:	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
>  L:	linux-iio@xxxxxxxxxxxxxxx
> 
> -- 
> 2.43.0
>