Re: [PATCH] HID: asus: fix touchpad multitouch initialization regression

[Greg KH]

On Tue, Aug 18, 2026 at 10:25:27AM +0200, PANZ wrote:
> In Linux 7.1, commit 7253091766de ("HID: asus: do not abort probe when
> not necessary")
> and commit 0919db9f3583 ("HID: asus: always fully initialize devices")
> introduced regressions in the probe sequence for ASUS I2C/HID touchpads
> (such as on the ASUS E200HA):
> 
> 1. asus_start_multitouch() was placed inside the claimed input check block:
>      if (drvdata->input && (hdev->claimed & HID_CLAIMED_INPUT))
>    On ASUS touchpads, (hdev->claimed & HID_CLAIMED_INPUT) evaluates to
>    false during asus_probe(), skipping asus_start_multitouch().
> 
> 2. The asus_report_id_init loop in asus_probe() was executed unconditionally
>    for all devices, which sends keyboard initialization feature requests
>    (asus_kbd_init) to touchpad endpoints, corrupting touchpad probe state.
> 
> This patch fixes both issues by:
> - Skipping keyboard report initialization for touchpad devices (!drvdata->tp).
> - Moving asus_start_multitouch() outside the claimed input check block so
>   multitouch initialization is always executed for touchpads.
> 
> Tested on ASUS E200HA (where touchpad functionality is fully restored)
> and ASUS VivoBook Flip 14 TP401MA (confirming zero regressions).
> 
> Fixes: 7253091766de ("HID: asus: do not abort probe when not necessary")
> Fixes: 0919db9f3583 ("HID: asus: always fully initialize devices")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: ppanzenboeck <panz.development@xxxxxxxxx>


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot