Re: [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally

[Helge Deller]

On 8/17/26 19:09, Maciej W. Rozycki wrote:
> On Fri, 14 Aug 2026, Randy Dunlap wrote:
>
> > This driver cannot be built as a loadable module so testing for
> > "#ifdef MODULE" is not appropriate here.
> > Also, MODULE_LICENSE() is always available.
>
>   It might best be reordered to the end of file, cf. pmagb-b-fb.c, though
> I'm not sure if we want to be pedantic enough to do it with a separate
> change.

No need to send a seperate patch.
I've fixed it up accordingly and pushed the updated patch to the fbdev for-next
git tree while I added your Acked-by tags.

Helge

>  Anyway:
>
> Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>

>   NB making the driver modular ought to be trivial once this has become a
> platform device; I have converted all the TURBOchannel drivers already.
> I have hesitated poking at this one without a live specimen though.
>
>    Maciej