Re: [PATCH] media: uvcvideo: Skip frame descriptors with a zero computed size
From: Natasha Klaus
Date: Tue Aug 18 2026 - 05:48:06 EST
On Tue, Aug 18, 2026, Ricardo Ribalda wrote:
> I think we need to have some consistency. We cannot have one
> condition returning -EINVAL and the other skipping it.
Agreed, and your shape is cleaner than mine.
> If Noam is okay with this, perhaps Natasha could prepare a patchset
> with the 3 patches? (keeping Noams author on his patch)
Happy to. Noam, are you okay with me carrying your patch in a series?
One question on placement before I write it. Your comment puts the checks after
the frame interval parsing, which is outside the !UVC_FMT_FLAG_COMPRESSED
branch. Frame based formats legitimately carry a zero
dwMaxVideoFrameBufferSize, set unconditionally at uvc_driver.c:265 because the
frame based frame descriptor has no such field, so a zero check there would skip
every frame of a conformant frame based device. Did you mean the checks stay
inside the branch with only the return value changing to -EINVAL, or outside
with an explicit frame based exemption?
I will test the refactor before sending.
The Media CI failure on my patch is the missing dependency on Noam's v2. The
series fixes that.
Natasha