Re: [PATCH] Bluetooth: hci_bcm4377: Ignore reserved PHY in ext adv reports on BCM4378

[Sven Peter]

On 18.08.26 11:49, Lorenzo Stoakes (ARM) wrote:
> Commit ed2a2ef16a6b ("Bluetooth: Add quirk to ignore reserved PHY bits in
> LE Extended Adv Report") added a quirk to handle creative use of the
> reserved bits in the PHY fields for 4388 controllers in Apple silicon.
>
> I observed the same issue with the BCM4378 Bluetooth controller (14e4:5f69,
> rev 05) on an Apple MacBook Pro (13-inch, M2, 2022):
>
> > HCI Event: LE Meta Event (0x3e) plen 51
>        LE Extended Advertising Report (0x0d)
>          Num reports: 1
>          Entry 0
>            Event type: 0x2513
>              Props: 0x0013
>                Connectable
>                Scannable
>                Use legacy advertising PDUs
>              Data status: Complete
>              Reserved (0x2500)
>            Legacy PDU Type: Reserved (0x2513)
>            Address type: Random (0x01)
>            Address: EA:C1:82:F0:24:C6 (Static)
>            Primary PHY: Reserved
>            Secondary PHY: No packets
>            SID: no ADI field (0xff)
>            TX power: 127 dBm
>            RSSI: -57 dBm (0xc7)
>            Periodic advertising interval: 0.00 msec (0x0000)
>            Direct address type: Public (0x00)
>            Direct address: 00:00:00:00:00:00 (OUI 00-00-00)
>            Data length: 25
>
> This results in the firmware rejecting connection attempts with
> "Unsupported Feature or Parameter Value" (0x11).
>
> Fix the issue by using the same quirk for BCM4378 devices too.
>
> I tested this locally and confirmed that the issue is resolved.
>
> This was observed when attempting to connect a Kinesis Advantage 360
> keyboard to the MacBook.
>
> Assisted-by: Claude:claude-fable-5
> Fixes: 2e7ed5f5e69b ("Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> ---

Reviewed-by: Sven Peter <sven@xxxxxxxxxx>

Kinda surprised no one ran into this so far tbh.


Best,


Sven