Re: [PATCH v2 0/4] sysctl: Disallow partial updates of miss-formatted sysctl vectors

[Joel Granados]

On Sat, Aug 15, 2026 at 05:09:30PM +0100, Bradley Morgan wrote:
> 
> Copy it, only write back once every value converted. That's the
> right way to do this. Went through the whole series against the
> tree, notes in the patch replies.
Your feedback was useful, but it was riddled with a *lot* of hand
waving. Please be succinct and to the point. The previous paragraph is
not needed.

> 
> Some nits on the series:
> - "miss-formatted" in the subject. mis-formatted, or just malformed.
Note that this comment is missing the why. It is good to know why you
want the change

> - akpm's scalars nit still applies.
> - Sashiko saw something on this one (akpm linked it).
In my opinion this is just noise. If you see that I have missed a
comment, call me out on it. If you have additional information, answer
to reviewers mail. 

> 
> Otherwise fine by me, the split is clean.
> 
> 
> Reviewed-by: Bradley Morgan <include@xxxxxxxxx>
> also
> 
> Tested-by: Bradley Morgan <include@xxxxxxxxx> for the test
How did you test? And what where your results?

Best

Attachment: signature.asc
Description: PGP signature