Re: [PATCH v7 2/4] iio: light: add support for veml6031x00 ALS series

From: Andy Shevchenko

Date: Tue Aug 18 2026 - 09:32:18 EST


On Tue, Aug 18, 2026 at 01:34:27PM +0200, Javier Carrasco wrote:
> Support device identification, raw ALS and IR readings, and configuration
> of the scale and integration time.

...

> +static void veml6031x00_als_shutdown_action(void *data)
> +{
> + struct veml6031x00_data *priv = data;

struct device *dev = regmap_get_device(priv->regmap);

> + int ret;
> +
> + ret = veml6031x00_set_power(priv, false);
> + if (ret)
> + dev_warn(regmap_get_device(priv->regmap),
> + "Failed to shut down device: %d\n", ret);

dev_warn(dev, "Failed to shut down device: %d\n", ret);

> +}

Same amount of LoC, but more flexible and scalable.

...

No need to resend just for this, the rest seems fine to me.

--
With Best Regards,
Andy Shevchenko