Re: [PATCH] mlxbf-bootctl: fix the build error with FIELD_PREP()
From: Ilpo Järvinen
Date: Tue Aug 18 2026 - 10:17:55 EST
On Mon, 10 Aug 2026 22:10:02 +0300, Nikolay Kulikov wrote:
> rsh_log_store() calls the FIELD_PREP() macro without including the
> required header file, resulting a build error:
>
> CC drivers/platform/mellanox/mlxbf-bootctl.o
> drivers/platform/mellanox/mlxbf-bootctl.c: In function ‘rsh_log_store’:
> drivers/platform/mellanox/mlxbf-bootctl.c:429:16: error: implicit declaration of function ‘FIELD_PREP’ [-Wimplicit-function-declaration]
> 429 | data = FIELD_PREP(MLXBF_RSH_LOG_TYPE_MASK, MLXBF_RSH_LOG_TYPE_MSG);
> | ^~~~~~~~~~
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] mlxbf-bootctl: fix the build error with FIELD_PREP()
commit: cb361aba6ac9a7d336e4b6e503fec6d84851e709
--
i.