Re: [PATCH v5 00/10] media: microchip-isc: AWB, stream-stop and endpoint-ref fixes

[Eugen Hristev]

On 8/17/26 09:51, Balakrishnan Sambath wrote:
> This series has a few fixes for the Microchip ISC/XISC driver, found
> while testing and from the feedback on the combined series [1].
> 
> Fixes only, sent ahead of the enhancements so they can reach stable.
> All but the two pfe_cfg0_bps cleanups carry a Fixes tag and Cc: stable.
> 
> [1] https://lore.kernel.org/r/20260603-microchip-isc-fixes-v6-0-8c3d7474a768@xxxxxxxxxxxxx
> 
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
> ---
> Changes in v5:
> - Put the endpoint of_node_put() inside the parse loop; take a
>   reference on the stored endpoint (Eugen).
> - Move the histogram-disable and AWB flush into isc_configure() on the
>   isc_update_profile() failure path (Eugen).
> - Collect Eugen's Reviewed-by on the awb_mutex, WB-not-streaming and
>   WB-masking patches.
> - Link to v4: https://lore.kernel.org/r/20260803-balki-isc-prefix-fixes-v1-v4-0-f625d6aa0ae1@xxxxxxxxxxxxx
> 
> Changes in v4:
> - Retarget the Fixes: tags to the atmel-isc commits that introduced
>   each bug; microchip-isc is a verbatim copy, so the real origin is
>   older. Kept the Reviewed-by tags as only the Fixes: SHAs changed.
>   Let me know if you disagree.
> - Init the ISC mutexes with devm_mutex_init() at probe, and drop the
>   dead isc_async_complete_err label (Eugen).
> - Drop a stale FIELD_PREP comment.
> - Link to v3: https://lore.kernel.org/r/20260721-balki-isc-prefix-fixes-v1-v3-0-ffe10640a2d9@xxxxxxxxxxxxx
> 
> Changes in v3:
> - Rewrite the WB offset/gain register writes with FIELD_PREP() (Eugen). No
>   functional change; verified on SAMA7G5-EK.
> - Collect Eugen's Reviewed-by on the PFE_CFG0 and macro-typo patches.
> - Link to v2: https://lore.kernel.org/r/20260629-balki-isc-prefix-fixes-v1-v2-0-3b120cc3742f@xxxxxxxxxxxxx
> 
> Changes in v2:
> - Squash the stop and start-error histogram/AWB-flush patches into one (Eugen).
> - Store pfe_cfg0_bps unshifted, apply with FIELD_PREP() at the write (Eugen).
> - Skip the WB register writes during the stop window too (isc->stop check).
> - New patch: fix the ISC_PFG_CFG0_BPS macro name typo.
> - Add Eugen's Reviewed-by on the IRQ-sync patch.
> - Link to v1: https://lore.kernel.org/r/20260616-balki-isc-prefix-fixes-v1-v1-0-b23677fc5ab6@xxxxxxxxxxxxx
> 
> ---
> Balakrishnan Sambath (10):
>       media: microchip-isc: fix awb_mutex and lock lifecycle
>       media: microchip-isc: take a reference on the parsed endpoints
>       media: microchip-isc: synchronize the IRQ before disabling clocks on stop
>       media: microchip-isc: disable histogram and flush AWB work on teardown
>       media: microchip-isc: do not touch WB registers when not streaming
>       media: microchip-isc: store the unshifted PFE_CFG0 BPS value
>       media: microchip-isc: fix ISC_PFG_CFG0_BPS macro name typo
>       media: microchip-isc: fix PM runtime leak in AWB work handler
>       media: microchip-isc: fix SBGGR10 Bayer pattern
>       media: microchip-isc: fix WB offset and gain register field masking
> 
>  .../media/platform/microchip/microchip-isc-base.c  | 82 ++++++++++++++--------
>  .../media/platform/microchip/microchip-isc-regs.h  | 16 +++--
>  drivers/media/platform/microchip/microchip-isc.h   |  5 +-
>  .../platform/microchip/microchip-sama5d2-isc.c     | 48 +++++++++----
>  .../platform/microchip/microchip-sama7g5-isc.c     | 48 +++++++++----
>  5 files changed, 133 insertions(+), 66 deletions(-)
> ---
> base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
> change-id: 20260615-balki-isc-prefix-fixes-v1-c8c44224caa1
> 
> Best regards,


All,

I reviewed the whole series to the best of my ability, from my
perspective it's good to go.
I will leave it to Hans or others to have a look if it's good enough to
be merged.

Eugen