Re: [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error
From: Jakub Kicinski
Date: Tue Aug 18 2026 - 12:07:49 EST
On Wed, 12 Aug 2026 20:00:11 -0700 Selvamani Rajagopal via B4 Relay
wrote:
> + /* disable_traffic, when set, is a point of no return to working
> + * state. TX queues are disabled. In some cases, upper layer or
> + * vendor code may inadvertently enable the queue. Intention of
> + * the disable_traffic flag is to stop traffic from flowing.
> + */
I don't get this comment and why this isn't part of patch 1.
Patch 1 is the place where the stop is removed:
- if (tc6->disable_traffic || tc6->waiting_tx_skb) {
- netif_stop_queue(tc6->netdev);
- return NETDEV_TX_BUSY;
- }
Also the "vendor code may inadvertently enable the queue"
is some vague indication of a race? I have no idea what "vendor code"
means here, this "library" has one user. If there is a race please fix
it. If there's not - please don't add confusing comments.