Re: [PATCH net v2 1/5] net: phy: split phy_probe() error paths

[Jakub Kicinski]

On Thu, 13 Aug 2026 21:29:41 +0800 Xuanqiang Luo wrote:
> +out_led_triggers:

the labels should include the verb

out_unreg_led_triggers:

> +	if (!phydev->is_on_sfp_module)
> +		phy_led_triggers_unregister(phydev);
> +
> +out_ports:

out_sfp_release:

>  	sfp_bus_del_upstream(phydev->sfp_bus);
>  	phydev->sfp_bus = NULL;
>  
>  	phy_cleanup_ports(phydev);
>  
> -	if (!phydev->is_on_sfp_module)
> -		phy_led_triggers_unregister(phydev);
> -
> +out_reset:

this one is fine

>  	/* Re-assert the reset signal on error */
>  	phy_device_reset(phydev, 1);