Re: [PATCH v3 6/6] iio: adc: ad7768-1: add support for multiple chip aggregation
From: Nuno Sá
Date: Tue Aug 18 2026 - 12:21:35 EST
On Mon, 17 Aug 2026 20:33:41 -0300, Jonathan Santos <Jonathan.Santos@xxxxxxxxxx> wrote:
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index e9060c1bbe6f..deff36165ed1 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -1830,6 +1892,15 @@ static int ad7768_probe(struct spi_device *spi)
>
> st->chip = spi_get_device_match_data(spi);
> st->spi = spi;
> + /*
> + * This family is composed of single-lane devices, so we assume that
> + * each lane is bound to a different device.
> + */
> + st->num_devices = spi->num_rx_lanes;
I still don't agree with the above! At the very least we should infer
st->num_devices from the number of chipselects. Anyways, won't extend
much the review for now given that David seems to have some ideas
different from the ancillary devices.
- Nuno Sá
--
Nuno Sá <nuno.sa@xxxxxxxxxx>