Re: [PATCH net v7 1/7] net: mana: reference-count CQs looked up from the EQ handler

[Jakub Kicinski]

On Thu, 13 Aug 2026 10:42:33 -0700 Long Li wrote:
>  }
>  
> +static struct gdma_queue *mana_gd_get_cq(struct gdma_context *gc, u32 cq_id);
> +static void mana_gd_put_cq(struct gdma_queue *cq);

Forward declarations are considered a bad smell in the kernel.
Please add these functions here, I don't see a reason for this
they are purely calling kernel APIs.

>  static void mana_gd_process_eqe(struct gdma_queue *eq)
-- 
pw-bot: cr