Re: [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error

From: Jakub Kicinski

Date: Tue Aug 18 2026 - 12:33:52 EST


On Tue, 18 Aug 2026 16:23:58 +0000 Selvamani Rajagopal wrote:
> > Also the "vendor code may inadvertently enable the queue"
> > is some vague indication of a race? I have no idea what "vendor code"
> > means here, this "library" has one user. If there is a race please fix
> > it. If there's not - please don't add confusing comments.
>
> It is not a race. If vendor's code (or even from command line) marks
> the interface "down" followed by "up", queue may be re-enabled.

Due to a link event? That's a run of the mill situation in drivers
and has to be handled by correctly ordering the events.
I think you shut down the IRQ first, so that's good, not sure if there's
anything else to worry about

> This use case was raised by AI review during the previous submission,
> which is a valid question. So I thought I should capture this in the
> comment.

The comment is confusing.