Re: [PATCH net-next v10 1/4] net: dsa: motorcomm: Move to subdirectory

[Jakub Kicinski]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
---
net: dsa: motorcomm: Move to subdirectory

The yt921x DSA driver is moved from drivers/net/dsa/yt921x.[ch] into a new
drivers/net/dsa/motorcomm/ subdirectory as chip.[ch], with the Kconfig
symbol and the build rule moved into new per-directory Kconfig and Makefile
files.  MAINTAINERS is updated to match the new path.

> diff --git a/drivers/net/dsa/motorcomm/Kconfig b/drivers/net/dsa/motorcomm/Kconfig
> new file mode 100644
> index 0000000000000..1fddd386f866c
> --- /dev/null
> +++ b/drivers/net/dsa/motorcomm/Kconfig
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: ISC
> +config NET_DSA_YT921X
> +	tristate "Motorcomm YT9215 ethernet switch chip support"
> +	select NET_DSA_TAG_YT921X
> +	select NET_IEEE8021Q_HELPERS if DCB
> +	help
> +	  This enables support for the Motorcomm YT9215 ethernet switch
> +	  chip.
> diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm/Makefile
> new file mode 100644
> index 0000000000000..afd03be9fa35c
> --- /dev/null
> +++ b/drivers/net/dsa/motorcomm/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: ISC
    ^^^

[Severity: Low]
Is the ISC tag on the two new files intentional?  Both
drivers/net/dsa/motorcomm/Kconfig and drivers/net/dsa/motorcomm/Makefile
start with:

    # SPDX-License-Identifier: ISC

but the text in them was moved verbatim out of files carrying a different
tag:

    drivers/net/dsa/Kconfig:  # SPDX-License-Identifier: GPL-2.0-only
    drivers/net/dsa/Makefile: # SPDX-License-Identifier: GPL-2.0

so the same config block and the same obj-$(CONFIG_NET_DSA_YT921X) line now
appear under two different licenses.

The sources these files build are also tagged differently:

    drivers/net/dsa/motorcomm/chip.c: // SPDX-License-Identifier: GPL-2.0-or-later
    drivers/net/dsa/motorcomm/chip.h: /* SPDX-License-Identifier: GPL-2.0-or-later */

ISC only exists in the tree as LICENSES/deprecated/ISC, and
Documentation/process/license-rules.rst says about that set:

    2. Deprecated licenses:

       These licenses should only be used for existing code or for importing
       code from a different project.

These two files are newly created and not imported from another project.
Every other DSA subdirectory (b53, hirschmann, microchip, mv88e6xxx,
mxl862xx, netc, ocelot, qca, realtek, sja1105, xrs700x) uses a GPL-2.0
variant for its Kconfig and Makefile, and these are the only ISC-tagged
files under drivers/net/dsa/.

Would GPL-2.0-only (matching the files the text came from) or
GPL-2.0-or-later (matching chip.c and chip.h) be the right tag here?  The
commit message describes the change as a mechanical relocation and does not
mention a licensing change.

> +obj-$(CONFIG_NET_DSA_YT921X) += yt921x.o
> +yt921x-objs := chip.o

[ ... ]
-- 
pw-bot: cr