Re: [PATCH v4 2/6] drm/ssd130x: Change SSD133X color format to RGB565 from RGB332

[Amit Barzilai]

On Tue, Aug 18, 2026 at 11:37 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
> > +     /*
> > +      * Horizontal address increment, normal SA,SB,SC (e.g. RGB) sub-pixel
> > +      * order, COM split odd even and 65k (RGB565) color depth.
> > +      */
> > +     u8 remap = SSD133X_SET_REMAP_COM_SPLIT |
> > +                FIELD_PREP(SSD133X_SET_REMAP_COLOR_DEPTH_MASK, SSD133X_COLOR_DEPTH_65K);
> >       const u8 cmds[] = {
> >               2, SSD133X_SET_MASTER_CURRENT, 0x06,
> >               3, SSD133X_SET_COL_RANGE, 0x00, ssd130x->width - 1,
> >               3, SSD133X_SET_ROW_RANGE, 0x00, ssd130x->height - 1,
> > -             /*
> > -              * Horizontal Address Increment
> > -              * Normal order SA,SB,SC (e.g. RGB)
> > -              * COM Split Odd Even
> > -              * 256 color format
> > -              */
> > -             2, SSD13XX_SET_SEG_REMAP, 0x20,
> > +             2, SSD13XX_SET_SEG_REMAP, remap,

Fair point, there is no downside to marking a variable that shouldn't change as
const. I'll change it in v5.

Thanks for the speedy reviews.
--
Thanks,
Amit