RE: [PATCH rtw-next v5] wifi: rtl8xxxu: Use local 'dev' variable for dev_warn()

[Ping-Ke Shih]

Please plain text only.

Rafael Alejandro Díaz Cruz <rafad900@xxxxxxxxx> wrote:
> There are multiple places where the dev variable would only be used once.
> I was hoping to only adjust the function calls that had &priv->udev->dev
> more than once to avoid redundancy.

I didn't get this point. As I come back to your first version [1], you
didn't mention and do this.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20260816180857.4122090-1-rafad900@xxxxxxxxx/

> But I'm a little confused because you mentioned in a previous patch:
> " If it is worth to do, please convert all of them. " I was hoping to
> change all the dev_warn(), dev_err(), dev_info(), dev_dbg() since they
> all use the same &priv->udev->dev but I was going to submit different
> patches for each one. Perhaps I should take another approach.
> I guess this change might not actually be worth the trouble. 

I didn't actually know your goal, so no idea if this is worth to stir
the code.

> Thanks for your patience and help with this patch. I'll put this off
> until I find something else to contribute with it. 

I dropped this from patchwork then.